(maint) - Make codecov gem support optional - changes to spec:simplecov rake task #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanbreen28
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
==========================================
- Coverage 41.90% 41.71% -0.19%
==========================================
Files 10 10
Lines 673 676 +3
==========================================
Hits 282 282
- Misses 391 394 +3 ☔ View full report in Codecov by Sentry. |
jordanbreen28
force-pushed
the
maint-remove_deprecated_codecov_gem
branch
from
6ae2284
to
bde61c5
Compare
ekohl
reviewed
Jan 16, 2024
jordanbreen28
force-pushed
the
maint-remove_deprecated_codecov_gem
branch
2 times, most recently
from
d3ce31b
to
ee6d8f7
Compare
jordanbreen28
changed the title
jordanbreen28
force-pushed
the
maint-remove_deprecated_codecov_gem
branch
from
ee6d8f7
to
765fab0
Compare
ekohl
approved these changes
Jan 19, 2024
|
Slight nit: I'd rephrase the title as "Make codecov support optional" instead of "Add". Add implies it wasn't there before, but it was. Also, there's a typo in |
jordanbreen28
changed the title
|
ah! derp. @ekohl Thanks for all your help on this one! |
bastelfreak
reviewed
Jan 19, 2024
The codecov gem is deprecated, thus we should try to avoid its use if possible. We still allow users to require and use this gem if installed in their environments.
jordanbreen28
force-pushed
the
maint-remove_deprecated_codecov_gem
branch
from
765fab0
to
89c244c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The codecov gem has been deprecated and unsupported for quite some time now. (2+ years).
This means we are restricted to outdated versions < 0.22 of simplecov which include bugs with ruby 3.2, and naturally wont be receiving further updates. (See here)
We should update the module_spec_helper file to only include this gem if installed by the user, else update documentation to guide users in how to now upload the coverage reports to codecov.io.
Additional Context
See codecov repo https://github.com/codecov/codecov-ruby
Related Issues (if any)
Mention any related issues or pull requests.
Checklist