Preserve directory mtimes #27
Merged
+31
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make module building more idempotent, this copies directory mtimes after copying files. The result is that when removing the staging directory and creating another the mtimes will be the same. Since creating or removing a file modifies a directory, it needs to happen after all files have been copied. This can be beneficial when using rsync to deploy.
ekohl
force-pushed
the
preserve-directory-mtime
branch
from
9d45789 to
d3b0a2c
Compare
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
+ Coverage 92.50% 93.06% +0.56%
==========================================
Files 2 2
Lines 160 173 +13
==========================================
+ Hits 148 161 +13
Misses 12 12
Continue to review full report at Codecov.
|
|
Hi @ekohl, Thank you for your contribution, this looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make module building more idempotent, this copies directory mtimes after copying files. The result is that when removing the staging directory and creating another the mtimes will be the same.
Since creating or removing a file modifies a directory, it needs to happen after all files have been copied.
This can be beneficial when using rsync to deploy.