Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: roll to Chrome 124.0.6367.60 (r1274542) #12305

Merged
merged 2 commits into from
Apr 23, 2024
Merged

feat: roll to Chrome 124.0.6367.60 (r1274542) #12305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5f5ded
feat: roll to Chrome 124.0.6367.60 (r1274542)
browser-automation-bot Apr 23, 2024
e4a3724
test: fix the a11y
OrKoN Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 8 additions & 8 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/puppeteer-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@
"@puppeteer/browsers": "2.2.2",
"chromium-bidi": "0.5.17",
"debug": "4.3.4",
"devtools-protocol": "0.0.1262051",
"devtools-protocol": "0.0.1273771",
"ws": "8.16.0"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions packages/puppeteer-core/src/revisions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
* @internal
*/
export const PUPPETEER_REVISIONS = Object.freeze({
chrome: '123.0.6312.122',
'chrome-headless-shell': '123.0.6312.122',
chrome: '124.0.6367.60',
'chrome-headless-shell': '124.0.6367.60',
firefox: 'latest',
});
2 changes: 1 addition & 1 deletion packages/puppeteer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@
"cosmiconfig": "9.0.0",
"puppeteer-core": "22.6.5",
"@puppeteer/browsers": "2.2.2",
"devtools-protocol": "0.0.1262051"
"devtools-protocol": "0.0.1273771"
},
"devDependencies": {
"@types/node": "18.17.15"
Expand Down
7 changes: 0 additions & 7 deletions test/TestExpectations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,13 +951,6 @@
"expectations": ["SKIP"],
"comment": "TODO: add a comment explaining why this expectation is required (include links to issues)"
},
{
"testIdPattern": "[accessibility.spec] Accessibility should work",
"platforms": ["darwin", "linux", "win32"],
"parameters": ["chrome", "webDriverBiDi"],
"expectations": ["FAIL"],
"comment": "Change in A11Y tree on Canary"
},
{
"testIdPattern": "[ariaqueryhandler.spec] AriaQueryHandler queryAllArray $$eval should handle many elements",
"platforms": ["darwin", "linux", "win32"],
Expand Down
4 changes: 2 additions & 2 deletions test/src/accessibility.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@ describe('Accessibility', function () {
value: 'First Option',
haspopup: 'menu',
children: [
{role: 'menuitem', name: 'First Option', selected: true},
{role: 'menuitem', name: 'Second Option'},
{role: 'option', name: 'First Option', selected: true},
{role: 'option', name: 'Second Option'},
],
},
],
Expand Down
3 changes: 2 additions & 1 deletion versions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
const versionsPerRelease = new Map([
// This is a mapping from Chrome version => Puppeteer version.
// In Chrome roll patches, use `NEXT` for the Puppeteer version.
['124.0.6367.60', 'NEXT'],
['123.0.6312.122', 'v22.6.4'],
['123.0.6312.105', 'v22.6.3'],
['123.0.6312.86', 'v22.6.2'],
Expand Down Expand Up @@ -71,7 +72,7 @@ const versionsPerRelease = new Map([
]);

// Should not be more than 2 major versions behind Chrome Stable (https://chromestatus.com/roadmap).
const lastMaintainedChromeVersion = '120.0.6099.109';
const lastMaintainedChromeVersion = '121.0.6167.85';

if (!versionsPerRelease.has(lastMaintainedChromeVersion)) {
throw new Error(
Expand Down