Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update the extensions guide #12290

Merged
merged 1 commit into from Apr 18, 2024
Merged

docs: update the extensions guide #12290

merged 1 commit into from Apr 18, 2024

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Apr 17, 2024

No description provided.

@OrKoN OrKoN force-pushed the orkon/update-extension-docs branch from c0992ef to bf125bd Compare April 17, 2024 18:52
@OrKoN
Copy link
Collaborator Author

OrKoN commented Apr 17, 2024

@oliverdunk PTAL

@OrKoN OrKoN marked this pull request as ready for review April 17, 2024 18:52
@OrKoN OrKoN force-pushed the orkon/update-extension-docs branch 2 times, most recently from bb406aa to c717963 Compare April 17, 2024 18:53
oliverdunk
oliverdunk approved these changes Apr 18, 2024
View reviewed changes
Copy link

@oliverdunk oliverdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex! I left a couple of notes but generally LGTM.

docs/guides/chrome-extensions.md Outdated Show resolved Hide resolved
docs/guides/chrome-extensions.md
:::note

It is not yet possible to test extension popups or content scripts.
It is not yet possible to test extension content scripts.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what the content script callout here was referring to? Or to put it another way, what would we want to exist before we could remove this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is about executing code in the content scripts created by extensions

docs/guides/chrome-extensions.md Show resolved Hide resolved
@OrKoN OrKoN force-pushed the orkon/update-extension-docs branch from c717963 to ebb9d68 Compare April 18, 2024 10:31
@OrKoN OrKoN enabled auto-merge (squash) April 18, 2024 10:32
@OrKoN OrKoN merged commit 3b70667 into main Apr 18, 2024
21 checks passed
@OrKoN OrKoN deleted the orkon/update-extension-docs branch April 18, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverdunk oliverdunk oliverdunk approved these changes

@Lightning00Blade Lightning00Blade Lightning00Blade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OrKoN @oliverdunk @Lightning00Blade