Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check if executablePath exists #12201

Merged
merged 1 commit into from Apr 4, 2024
Merged

fix: check if executablePath exists #12201

merged 1 commit into from Apr 4, 2024

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Apr 3, 2024

Closes #12025

@OrKoN OrKoN enabled auto-merge (squash) April 4, 2024 07:19
@Lightning00Blade
Copy link
Collaborator

@OrKoN Installation test are failing please update

@OrKoN
Copy link
Collaborator Author

OrKoN commented Apr 4, 2024

@Lightning00Blade I am aware, thanks

@OrKoN
Copy link
Collaborator Author

OrKoN commented Apr 4, 2024

should be fixed now

@OrKoN OrKoN merged commit 4ec0280 into main Apr 4, 2024
38 checks passed
@OrKoN OrKoN deleted the orkon/check-executable branch April 4, 2024 10:46
@release-please release-please bot mentioned this pull request Apr 4, 2024
Merged
@TonyRL TonyRL mentioned this pull request Apr 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lightning00Blade Lightning00Blade Lightning00Blade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: If pipe: true, if the executable fails to spawn, it will exit without throwing an error.
2 participants
@OrKoN @Lightning00Blade