fix: check if executablePath exists

Closes #12025
puppeteer · Apr 3, 2024 · 49ff86c · 49ff86c
1 parent d345055
commit 49ff86c
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/packages/puppeteer-core/src/node/ProductLauncher.ts b/packages/puppeteer-core/src/node/ProductLauncher.ts
@@ -98,6 +98,12 @@ export abstract class ProductLauncher {
 
     const launchArgs = await this.computeLaunchArguments(options);
 
+    if (!existsSync(launchArgs.executablePath)) {
+      throw new Error(
+        `Browser was not found at the configured executablePath (${launchArgs.executablePath})`
+      );
+    }
+
     const usePipe = launchArgs.args.includes('--remote-debugging-pipe');
 
     const onProcessExit = async () => {

diff --git a/test/src/launcher.spec.ts b/test/src/launcher.spec.ts
@@ -591,6 +591,20 @@ describe('Launcher specs', function () {
         });
         expect(error.message).toContain('either pipe or debugging port');
       });
+
+      it('throws an error if executable path is not valid', async () => {
+        const options = {
+          executablePath: '/tmp/does-not-exist',
+          pipe: true,
+        };
+        let error!: Error;
+        await launch(options).catch(error_ => {
+          return (error = error_);
+        });
+        expect(error.message).toContain(
+          'Browser was not found at the configured executablePath (/tmp/does-not-exist)'
+        );
+      });
     });
 
     describe('Puppeteer.launch', function () {