chore: don't detach CdpSession #12154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lightning00Blade
force-pushed
the
deatch-on-user-session-only
branch
from
36bbdbf
to
0f95582
Compare
|
Does it solve any bug/issue? |
|
There were Errors in the Logs, they are always cleaned up before the make the call so we get errors instead. |
OrKoN
reviewed
Mar 26, 2024
Lightning00Blade
force-pushed
the
deatch-on-user-session-only
branch
from
0f95582
to
f6b24ef
Compare
Lightning00Blade
changed the title
OrKoN
force-pushed
the
main
branch
4 times, most recently
from
2ff1e4f
to
e0932e5
Compare
Lightning00Blade
force-pushed
the
deatch-on-user-session-only
branch
from
f6b24ef
to
6a3b042
Compare
Lightning00Blade
force-pushed
the
deatch-on-user-session-only
branch
from
6a3b042
to
7ba043c
Compare
| @@ -106,7 +106,7 @@ export class BidiFrame extends Frame { | |||
| this.browsingContext.on('closed', () => { | |||
| for (const session of BidiCdpSession.sessions.values()) { | |||
| if (session.frame === this) { | |||
| void session.detach().catch(debugError); | |||
| session.onClose(); | |||
There was a problem hiding this comment.
If the BrowserContext is closed Mapper the session is already closed so we need to only remove it from the map.
OrKoN
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the Mapper to handle it's own clean-up, else w get errors in the logs + we send too many commands.
Users should clean the CdpSession on their own if created via
createCDPSession