chore: fix comments

puppeteer · Apr 19, 2024 · 6a3b042 · 6a3b042
1 parent 0598314
commit 6a3b042
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 14 deletions.
diff --git a/packages/puppeteer-core/src/bidi/CDPSession.ts b/packages/puppeteer-core/src/bidi/CDPSession.ts
@@ -21,15 +21,13 @@ export class BidiCdpSession extends CDPSession {
   static sessions = new Map<string, BidiCdpSession>();
 
   #detached = false;
-  #userCreated: boolean;
   readonly #connection: BidiConnection | undefined = undefined;
   readonly #sessionId = Deferred.create<string>();
   readonly frame: BidiFrame;
 
-  constructor(frame: BidiFrame, sessionId?: string, userCreated = false) {
+  constructor(frame: BidiFrame, sessionId?: string) {
     super();
     this.frame = frame;
-    this.#userCreated = userCreated;
     if (!this.frame.page().browser().cdpSupported) {
       return;
     }
@@ -95,16 +93,8 @@ export class BidiCdpSession extends CDPSession {
       return;
     }
 
-    try {
-      if (this.#userCreated) {
-        await this.frame.client.send('Target.detachFromTarget', {
-          sessionId: this.id(),
-        });
-      }
-    } finally {
-      BidiCdpSession.sessions.delete(this.id());
-      this.#detached = true;
-    }
+    BidiCdpSession.sessions.delete(this.id());
+    this.#detached = true;
   }
 
   override id(): string {

diff --git a/packages/puppeteer-core/src/bidi/Frame.ts b/packages/puppeteer-core/src/bidi/Frame.ts
@@ -475,7 +475,7 @@ export class BidiFrame extends Frame {
       flatten: true,
     });
     await this.browsingContext.subscribe([Bidi.ChromiumBidi.BiDiModule.Cdp]);
-    return new BidiCdpSession(this, sessionId, true);
+    return new BidiCdpSession(this, sessionId);
   }
 
   @throwIfDetached