Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webdriver): emit RequestServedFromCache for requests #12104

Merged
merged 4 commits into from Mar 19, 2024

Conversation

Lightning00Blade
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % remove the fail expectation

@Lightning00Blade
Copy link
Collaborator Author

@OrKoN Please rereview I need to fix the expectation formatter.

@Lightning00Blade
Copy link
Collaborator Author

@OrKoN after the last change this was the output - https://gist.github.com/Lightning00Blade/50916ff9d8926e5e3fb629ad4311a18a

log.log Outdated Show resolved Hide resolved
@OrKoN OrKoN enabled auto-merge (squash) March 19, 2024 14:27
@OrKoN OrKoN disabled auto-merge March 19, 2024 14:27
@Lightning00Blade Lightning00Blade enabled auto-merge (squash) March 19, 2024 15:14
@Lightning00Blade Lightning00Blade merged commit 6ba6bef into main Mar 19, 2024
38 checks passed
@Lightning00Blade Lightning00Blade deleted the emit-from-cache branch March 19, 2024 15:25
@release-please release-please bot mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants