fix(webdriver): emit RequestServedFromCache for requests

puppeteer · Mar 18, 2024 · 9b50b46 · 9b50b46
1 parent e058641
commit 9b50b46
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/puppeteer-core/src/bidi/HTTPRequest.ts b/packages/puppeteer-core/src/bidi/HTTPRequest.ts
@@ -68,7 +68,7 @@ export class BidiHTTPRequest extends HTTPRequest {
   }
 
   override resourceType(): ResourceType {
-    return this.initiator().type.toLowerCase() as ResourceType;
+    throw new UnsupportedOperation();
   }
 
   override method(): string {

diff --git a/packages/puppeteer-core/src/bidi/HTTPResponse.ts b/packages/puppeteer-core/src/bidi/HTTPResponse.ts
@@ -40,6 +40,12 @@ export class BidiHTTPResponse extends HTTPResponse {
   }
 
   #initialize() {
+    if (this.#data.fromCache) {
+      this.#request
+        .frame()
+        ?.page()
+        .trustedEmitter.emit(PageEvent.RequestServedFromCache, this.#request);
+    }
     this.#request.frame()?.page().trustedEmitter.emit(PageEvent.Response, this);
   }