fix: use handle frame instead of page (#10676)

puppeteer · Aug 3, 2023 · 1b44b91 · 1b44b91
1 parent 9a814a3
commit 1b44b91
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 1 deletion.
diff --git a/packages/puppeteer-core/src/api/locators/Locator.ts b/packages/puppeteer-core/src/api/locators/Locator.ts
@@ -322,7 +322,7 @@ export abstract class Locator<T> extends EventEmitter {
       return EMPTY;
     }
     return from(
-      handle.frame.page().waitForFunction(
+      handle.frame.waitForFunction(
         element => {
           if (!(element instanceof HTMLElement)) {
             return true;

diff --git a/test/TestExpectations.json b/test/TestExpectations.json
@@ -965,6 +965,12 @@
     "parameters": ["webDriverBiDi"],
     "expectations": ["PASS"]
   },
+  {
+    "testIdPattern": "[locator.spec] Locator Locator.click should work with a OOPIF",
+    "platforms": ["darwin", "linux", "win32"],
+    "parameters": ["webDriverBiDi"],
+    "expectations": ["FAIL"]
+  },
   {
     "testIdPattern": "[mouse.spec] Mouse should click the document",
     "platforms": ["darwin", "linux", "win32"],

diff --git a/test/src/locator.spec.ts b/test/src/locator.spec.ts
@@ -287,6 +287,31 @@ describe('Locator', function () {
         clock.restore();
       }
     });
+
+    it('should work with a OOPIF', async () => {
+      const {page} = await getTestState();
+
+      await page.setViewport({width: 500, height: 500});
+      await page.setContent(`
+        <iframe src="data:text/html,<button onclick=&quot;this.innerText = 'clicked';&quot;>test</button>"></iframe>
+      `);
+      const frame = await page.waitForFrame(frame => {
+        return frame.url().startsWith('data');
+      });
+      let willClick = false;
+      await frame
+        .locator('button')
+        .on(LocatorEmittedEvents.Action, () => {
+          willClick = true;
+        })
+        .click();
+      const button = await frame.$('button');
+      const text = await button?.evaluate(el => {
+        return el.innerText;
+      });
+      expect(text).toBe('clicked');
+      expect(willClick).toBe(true);
+    });
   });
 
   describe('Locator.hover', function () {