Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use the systemd plugin on JRuby #3079

Merged
merged 6 commits into from
Feb 24, 2023
Merged

Don't use the systemd plugin on JRuby #3079

merged 6 commits into from
Feb 24, 2023

Commits on Feb 12, 2023

  1. Don't use the systemd plugin on JRuby 

    The systemd integration will fail for JRuby at https://github.com/puma/puma/blob/e3d5794a7ebe47577ced4d4dfdd6a6cc969ded01/lib/puma/sd_notify.rb#L140, because JRuby doesn't support UNIX datagram sockets yet, and won't for a while. See jruby/jruby#6504. So turning it off here, so that JRuby users can integrate with systemd on their own if they wish without errors.
    @mohamedhafez
    mohamedhafez committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    2db2ac0 View commit details
    Browse the repository at this point in the history

  2. Improved skipping systemd for JRuby 

    Added a comment to explain the situation, and used Puma's JRuby detection method instead of re-coding it.
    @mohamedhafez
    mohamedhafez committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    b76bcd5 View commit details
    Browse the repository at this point in the history

  3. test that systemd plugin isn't loaded on JRuby

    @mohamedhafez
    mohamedhafez committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    5f9334e View commit details
    Browse the repository at this point in the history

  4. rename to test_plugin_systemd_jruby.rb, fix lint

    @mohamedhafez
    mohamedhafez committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    4384fb8 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. rename test to test_systemd_plugin_not_loaded

    @mohamedhafez
    mohamedhafez committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    bade6b3 View commit details
    Browse the repository at this point in the history

  2. make and use skip_unless :linux

    @mohamedhafez
    mohamedhafez committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    ddeea2e View commit details
    Browse the repository at this point in the history