Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request.rb - fix partial hijack precedence, refactor, add tests #3072

Merged
merged 8 commits into from
Feb 17, 2023
Merged

request.rb - fix partial hijack precedence, refactor, add tests #3072

merged 8 commits into from
Feb 17, 2023
+131 −84

Commits on Feb 16, 2023

  1. request.rb - set content_length earlier

    @MSP-Greg
    MSP-Greg committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    e3e224f View commit details
    Browse the repository at this point in the history

  2. request.rb - only compute content_length if res_body.respond_to? :each 

    which implies a partial hijack is not occurring.
    @MSP-Greg
    MSP-Greg committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    c6b0d7d View commit details
    Browse the repository at this point in the history

  3. Move response_hijack code into else clause

    @MSP-Greg
    MSP-Greg committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    dcd9b28 View commit details
    Browse the repository at this point in the history

  4. Sprockets::Asset's @source is always a string

    @MSP-Greg
    MSP-Greg committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    2f386e5 View commit details
    Browse the repository at this point in the history

  5. Fewer socket write with Enum chunked body

    @MSP-Greg
    MSP-Greg committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    8ba80de View commit details
    Browse the repository at this point in the history

  6. Add hijack comments

    @MSP-Greg
    MSP-Greg committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    f3d3061 View commit details
    Browse the repository at this point in the history

  7. Rearrange partial hijack tests, add full hijack test

    @MSP-Greg
    MSP-Greg committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    4bcf4ef View commit details
    Browse the repository at this point in the history

  8. Fix 'Did I do that?' mistakes...

    @MSP-Greg
    MSP-Greg committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    ab73c8f View commit details
    Browse the repository at this point in the history