Deserialize Assets with their Sig #16073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-04-26)Bug Fixes
|
This matches the behavior of Archives. Fixes pulumi/pulumi-go-provider#234
iwahbe
force-pushed
the
iwahbe/set-sig-when-deserializing-assets
branch
from
d32b488
to
c0d8b49
Compare
justinvp
approved these changes
Apr 26, 2024
thomas11
added a commit
to pulumi/pulumi-go-provider
that referenced
this pull request
Apr 29, 2024
Mainly to get pulumi/pulumi#16073, plus generally staying up to date. Also upgraded providertest.
iwahbe
added a commit
to pulumi/pulumi-go-provider
that referenced
this pull request
May 13, 2024
This locks in the behavior fix from pulumi/pulumi#16073. --------- Co-authored-by: Thomas Kappler <tkappler@pulumi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deserialize Assets with their Sig field set. This is necessary to round trip them. This matches the behavior of Archives.
Fixes pulumi/pulumi-go-provider#234
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change