Implement --continue-on-error for up in Automation API #15953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-04-23)Features
|
tgummerer
changed the title
up as well.
Users are already able to use --continue-on-error for destroy in the automation API. Implement the same for `up` as well.
tgummerer
force-pushed
the
tg/continue-on-error-auto
branch
from
c9d54dc
to
876c722
Compare
Frassle
reviewed
Apr 22, 2024
sdk/go/auto/optup/optup.go
Outdated
| @@ -193,6 +193,8 @@ type Options struct { | |||
| SuppressProgress bool | |||
| // Suppress display of stack outputs (in case they contain sensitive values) | |||
| SuppressOutputs bool | |||
| // ContinueOnError will continue updating resources even if a resource update fails | |||
There was a problem hiding this comment.
Why did this get different help text?
There was a problem hiding this comment.
I probably just trusted copilot a bit too much 😬 Made it the same as the others now.
tgummerer
force-pushed
the
tg/continue-on-error-auto
branch
from
876c722
to
aa8af55
Compare
12 tasks
Frassle
approved these changes
Apr 23, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
Tentative changelog, but also planning to include #16057 ### Features - [auto/{go,nodejs,python}] Add support for the continue-on-error parameter of the up command to the Automation API [#15953](#15953) - [engine] Add a --continue-on-error flag to pulumi up [#15740](#15740) ### Bug Fixes - [sdk/nodejs] Fix a race condition that could cause the NodeJS runtime to terminate before finishing all work [#16005](#16005) - [sdk/python] Fix an exception when setting providers resource option with a dict [#16022](#16022) - [sdk/python] Fix event loop tracking in the python SDK when using remote transforms [#16039](#16039) - [sdk/python] Workaround lazy module loading regression [#16038](#16038) ### Miscellaneous - [cli/plugin] Move PluginKind type definition into apitype and re-export for backward compatibility
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 26, 2024
Will wait to merge this until after #16057 merges ### Features - [auto/{go,nodejs,python}] Add support for the continue-on-error parameter of the up command to the Automation API [#15953](#15953) - [engine] Add a --continue-on-error flag to pulumi up [#15740](#15740) ### Bug Fixes - [sdk/nodejs] Fix a race condition that could cause the NodeJS runtime to terminate before finishing all work [#16005](#16005) - [sdk/python] Fix an exception when setting providers resource option with a dict [#16022](#16022) - [sdk/python] Fix event loop tracking in the python SDK when using remote transforms [#16039](#16039) - [sdk/python] Workaround lazy module loading regression [#16038](#16038) ### Miscellaneous - [cli/plugin] Move PluginKind type definition into apitype and re-export for backward compatibility [#15946](#15946)
6 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 31, 2024
<!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description This [PR](#15953) added support for `continue-on-error` to the Automation API. However this hardly usable without the corresponding function Option <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Fixes # (issue) ## Checklist - [ ] I have run `make tidy` to update any new dependencies - [ ] I have run `make lint` to verify my code passes the lint check - [ ] I have formatted my code using `gofumpt` <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- @pulumi employees: If yes, you must submit corresponding changes in the service repo. --> --------- Co-authored-by: Thomas Gummerer <t.gummerer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users are already able to use --continue-on-error for destroy in the automation API. Implement the same for
upas well.This should only be merged after #15740 is. (Note that this still includes the commits from there, I will rebase once that PR is merged, hence this is only a draft PR for now)