Program dependencies aren't necessarily semantic versions #15409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-02-08)Bug Fixes
|
This weakens the contract of GetProgramDependencies that the versions returned are just "strings". The format of those strings is defined by the language plugin. This is especially useful for python which uses PEP440 not semantic versions for it's pip dependencies. There wasn't anywhere in the system that took a strong dependency on these being semvers.
Frassle
force-pushed
the
fraser/programDependencies
branch
from
f5ad875
to
2e39105
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 15, 2024
### Features
- [components] Component providers can return output values in their
response to the engine.
- [programgen/{dotnet,go,nodejs,python}] Emit missing trivia for
resources and local variables
[#15419](#15419)
### Bug Fixes
- [engine] Engine no longer assumes program dependencies are specified
as semantic versions.
[#15409](#15409)
- [components/go] Component providers now correctly return output values
to the engine.
[#15405](#15405)
### Miscellaneous
- [protobuf] Split CallRequest into ResourceCallRequest for the
ResourceMonitor service.
[#15404](#15404)
- [backend/diy] Add a warning that non-project mode will be deprecated
at some point.
[#15411](#15411)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
### Features - [components] Component providers can return output values in their response to the engine. [#15408](#15408) - [programgen/{dotnet,go,nodejs,python}] Emit missing trivia for resources and local variables [#15419](#15419) - [sdk/{nodejs,python}] Publish dev versions of the nodejs and python SDKs ### Bug Fixes - [cli] Fix `pulumi destroy` to fill in stack config with the secret config from state, not fresh secret config. [#15432](#15432) - [engine] Engine no longer assumes program dependencies are specified as semantic versions. [#15409](#15409) - [components/go] Component providers now correctly return output values to the engine. [#15405](#15405) ### Miscellaneous - [protobuf] Split CallRequest into ResourceCallRequest for the ResourceMonitor service. [#15404](#15404) - [backend/diy] Add a warning that non-project mode will be deprecated at some point. [#15411](#15411)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This weakens the contract of GetProgramDependencies that the versions returned are just "strings". The format of those strings is defined by the language plugin. This is especially useful for python which uses PEP440 not semantic versions for it's pip dependencies.
There wasn't anywhere in the system that took a strong dependency on these being semvers.
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change