-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish dev versions of the python and node SDKs #15299
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-02-15)Features
|
tgummerer
force-pushed
the
tg/dev-sdk
branch
3 times, most recently
from
January 29, 2024 16:57
a7264dd
to
b036665
Compare
Publish dev versions of the python and node SDKs, so we can consume them pre-release and make our releases more stable. Also clean up the publish_npm.sh script a little bit, removing now unused cruft.
I'm not sure how to test this other than just "testing it in production". For that I've commented out the bits to only publish for new changes, so we don't need to change anything in the SDK for a new dev version to be published. The plan is to just keep a close eye on the CI job, and see that everything works. |
Frassle
approved these changes
Feb 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 7, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 7, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 9, 2024
tgummerer
force-pushed
the
tg/dev-sdk
branch
3 times, most recently
from
February 9, 2024 19:47
71b2c3d
to
17277bd
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 9, 2024
tgummerer
force-pushed
the
tg/dev-sdk
branch
2 times, most recently
from
February 15, 2024 12:13
a556d5a
to
8e4f740
Compare
tgummerer
force-pushed
the
tg/dev-sdk
branch
from
February 15, 2024 12:58
8e4f740
to
9b6c98f
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 15, 2024
tgummerer
force-pushed
the
tg/dev-sdk
branch
from
February 15, 2024 16:09
9b6c98f
to
20d9264
Compare
tgummerer
added a commit
that referenced
this pull request
Feb 15, 2024
In #15299 we changed the versioning scheme of dev releases slightly, as npm and python have slightly different requirements. However this also means that names of CLI dev releases changed, and thus downloads failed. Fix that by updating the latest-dev-version file to the new versioning scheme.
6 tasks
tgummerer
added a commit
that referenced
this pull request
Feb 15, 2024
In #15299 we changed the versioning scheme of dev releases slightly, as npm and python have slightly different requirements. However this also means that names of CLI dev releases changed, and thus downloads failed. Fix that by updating the latest-dev-version file to the new versioning scheme.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
In #15299 we changed the versioning scheme of dev releases slightly, as npm and python have slightly different requirements. However this also means that names of CLI dev releases changed, and thus downloads failed. Fix that by updating the latest-dev-version file to the new versioning scheme. Fixes #15443 ## Checklist - [ ] I have run `make tidy` to update any new dependencies - [ ] I have run `make lint` to verify my code passes the lint check - [ ] I have formatted my code using `gofumpt` <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- @pulumi employees: If yes, you must submit corresponding changes in the service repo. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publish dev versions of the python and node SDKs, so we can consume them pre-release and make our releases more stable.
Also clean up the publish_npm.sh script a little bit, removing now unused cruft.