Change Go's import path to a dynamic specific path with version #2330
+5
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenelinMartinov
approved these changes
Aug 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2330 +/- ##
==========================================
- Coverage 56.99% 56.99% -0.01%
==========================================
Files 366 366
Lines 50096 50096
==========================================
- Hits 28554 28552 -2
- Misses 19975 19976 +1
- Partials 1567 1568 +1 ☔ View full report in Codecov by Sentry. |
iwahbe
force-pushed
the
iwahbe/correctly-set-version
branch
from
0a3854e to
b00c760
Compare
julienp
reviewed
Aug 21, 2024
This change provides 2 benefits: 1. It prevents a static SDK from conflicting with a dynamic SDK. 2. It correctly includes the major version of the generated SDK in the path.
iwahbe
force-pushed
the
iwahbe/correctly-set-version
branch
from
b00c760 to
950a85a
Compare
julienp
approved these changes
Aug 21, 2024
|
This PR has been shipped in release v3.90.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change provides 2 benefits: