Run lint in parallel #1868
Merged
Run lint in parallel #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwahbe
force-pushed
the
iwahbe/run-lint-in-parallel
branch
3 times, most recently
from
386f0a4
to
53f53b9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1868 +/- ##
==========================================
- Coverage 61.02% 60.47% -0.55%
==========================================
Files 303 310 +7
Lines 42457 42835 +378
==========================================
- Hits 25909 25905 -4
- Misses 15075 15457 +382
Partials 1473 1473 ☔ View full report in Codecov by Sentry. |
iwahbe
force-pushed
the
iwahbe/run-lint-in-parallel
branch
from
53f53b9
to
baf6b95
Compare
VenelinMartinov
approved these changes
Apr 12, 2024
|
🔥 |
This reduces duplication and ensures that master.yml and ci.yml remain in sync. This ensures that master runs the same set of tests as ci, causing master to also run tests for both go versions.
iwahbe
force-pushed
the
iwahbe/run-lint-in-parallel
branch
from
baf6b95
to
8b1302e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About a third of CI time in this repo is spent running lints. The lints are extremely valuable, but don't need to be run synchronously with tests. Further, we don't need to run lints for the full matrix of test target.
A representative CI run breaks down as:
At the cost of spinning up an additional ubuntu-latest runner, we should be able to decrease end-to-end CI times by more then 20% without a loss in fidelity.