Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance docs for resources that depend on Lambda ENIs #4392

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

flostadler
Copy link
Contributor

The ENIs created by AWS Lambda get slowly cleaned up (~35mins) and because of that the provider has special delete logic for subnets and security groups that are associated with Lambda ENIs.
For cleaning those up, it will wait up to 45 minutes until the ENIs are freed up even if users specify a shorter timeout. See Source Code.

This change makes it clearer in the docs that this is happening.

resolves #4382

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@flostadler flostadler requested review from t0yv0, corymhall and a team August 22, 2024 17:07
@flostadler flostadler self-assigned this Aug 22, 2024
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@flostadler flostadler merged commit 7313dc5 into master Aug 23, 2024
31 checks passed
@flostadler flostadler deleted the flostadler/lambda-eni-delete-docs branch August 23, 2024 11:17
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v6.51.0.

lumiere-bot bot referenced this pull request in coolguy1771/home-ops Sep 8, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@pulumi/aws](https://pulumi.io)
([source](https://redirect.github.com/pulumi/pulumi-aws)) | dependencies
| minor | [`6.50.1` ->
`6.51.0`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.50.1/6.51.0)
|

---

### Release Notes

<details>
<summary>pulumi/pulumi-aws (@&#8203;pulumi/aws)</summary>

###
[`v6.51.0`](https://redirect.github.com/pulumi/pulumi-aws/releases/tag/v6.51.0)

[Compare
Source](https://redirect.github.com/pulumi/pulumi-aws/compare/v6.50.1...v6.51.0)

##### Does the PR have any schema changes?

Found 1 breaking change:

##### Resources

- `🟢`
"aws:drs/replicationConfigurationTemplate:ReplicationConfigurationTemplate":
required inputs: "stagingAreaTags" input has changed to Required

##### New resources:

-   `glue/catalogTableOptimizer.CatalogTableOptimizer`

##### New functions:

-   `shield/getProtection.getProtection`

##### What's Changed

- Enhance docs for resources that depend on Lambda ENIs by
[@&#8203;flostadler](https://redirect.github.com/flostadler) in
[https://github.com/pulumi/pulumi-aws/pull/4392](https://redirect.github.com/pulumi/pulumi-aws/pull/4392)
- Start running upstream tests for waf and sqs by
[@&#8203;t0yv0](https://redirect.github.com/t0yv0) in
[https://github.com/pulumi/pulumi-aws/pull/4384](https://redirect.github.com/pulumi/pulumi-aws/pull/4384)
- Upgrade upstream to v5.64.0 by
[@&#8203;flostadler](https://redirect.github.com/flostadler) in
[https://github.com/pulumi/pulumi-aws/pull/4395](https://redirect.github.com/pulumi/pulumi-aws/pull/4395)
- Add example for deploying an application from the serverless app
repository by
[@&#8203;flostadler](https://redirect.github.com/flostadler) in
[https://github.com/pulumi/pulumi-aws/pull/4396](https://redirect.github.com/pulumi/pulumi-aws/pull/4396)
- Update region list by
[@&#8203;corymhall](https://redirect.github.com/corymhall) in
[https://github.com/pulumi/pulumi-aws/pull/4404](https://redirect.github.com/pulumi/pulumi-aws/pull/4404)
- Move GRPC tests to yaml by
[@&#8203;VenelinMartinov](https://redirect.github.com/VenelinMartinov)
in
[https://github.com/pulumi/pulumi-aws/pull/4409](https://redirect.github.com/pulumi/pulumi-aws/pull/4409)
- Update GitHub Actions workflows. by
[@&#8203;pulumi-bot](https://redirect.github.com/pulumi-bot) in
[https://github.com/pulumi/pulumi-aws/pull/4420](https://redirect.github.com/pulumi/pulumi-aws/pull/4420)
- Rename the custom workflow to avoid deletion by ci-mgmt PRs by
[@&#8203;t0yv0](https://redirect.github.com/t0yv0) in
[https://github.com/pulumi/pulumi-aws/pull/4418](https://redirect.github.com/pulumi/pulumi-aws/pull/4418)
- Update GitHub Actions workflows. by
[@&#8203;pulumi-bot](https://redirect.github.com/pulumi-bot) in
[https://github.com/pulumi/pulumi-aws/pull/4423](https://redirect.github.com/pulumi/pulumi-aws/pull/4423)
- Enable PlanResourceChange by
[@&#8203;t0yv0](https://redirect.github.com/t0yv0) in
[https://github.com/pulumi/pulumi-aws/pull/4419](https://redirect.github.com/pulumi/pulumi-aws/pull/4419)
- Upstream 5.65.0 by [@&#8203;t0yv0](https://redirect.github.com/t0yv0)
in
[https://github.com/pulumi/pulumi-aws/pull/4425](https://redirect.github.com/pulumi/pulumi-aws/pull/4425)
- Update GitHub Actions workflows. by
[@&#8203;pulumi-bot](https://redirect.github.com/pulumi-bot) in
[https://github.com/pulumi/pulumi-aws/pull/4434](https://redirect.github.com/pulumi/pulumi-aws/pull/4434)
- Update GitHub Actions workflows. by
[@&#8203;pulumi-bot](https://redirect.github.com/pulumi-bot) in
[https://github.com/pulumi/pulumi-aws/pull/4436](https://redirect.github.com/pulumi/pulumi-aws/pull/4436)
- Upgrade pulumi-terraform-bridge to v3.90.0 by
[@&#8203;pulumi-bot](https://redirect.github.com/pulumi-bot) in
[https://github.com/pulumi/pulumi-aws/pull/4439](https://redirect.github.com/pulumi/pulumi-aws/pull/4439)

**Full Changelog**:
pulumi/pulumi-aws@v6.50.1...v6.51.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://redirect.github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43MS4wIiwidXBkYXRlZEluVmVyIjoiMzguNzEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsidHlwZS9taW5vciJdfQ==-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
lumiere-bot bot referenced this pull request in coolguy1771/home-ops Sep 8, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@pulumi/aws](https://pulumi.io)
([source](https://redirect.github.com/pulumi/pulumi-aws)) | dependencies
| minor | [`6.50.1` ->
`6.51.0`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.50.1/6.51.0)
|

---

### Release Notes

<details>
<summary>pulumi/pulumi-aws (@&#8203;pulumi/aws)</summary>

###
[`v6.51.0`](https://redirect.github.com/pulumi/pulumi-aws/releases/tag/v6.51.0)

[Compare
Source](https://redirect.github.com/pulumi/pulumi-aws/compare/v6.50.1...v6.51.0)

##### Does the PR have any schema changes?

Found 1 breaking change:

##### Resources

- `🟢`
"aws:drs/replicationConfigurationTemplate:ReplicationConfigurationTemplate":
required inputs: "stagingAreaTags" input has changed to Required

##### New resources:

-   `glue/catalogTableOptimizer.CatalogTableOptimizer`

##### New functions:

-   `shield/getProtection.getProtection`

##### What's Changed

- Enhance docs for resources that depend on Lambda ENIs by
[@&#8203;flostadler](https://redirect.github.com/flostadler) in
[https://github.com/pulumi/pulumi-aws/pull/4392](https://redirect.github.com/pulumi/pulumi-aws/pull/4392)
- Start running upstream tests for waf and sqs by
[@&#8203;t0yv0](https://redirect.github.com/t0yv0) in
[https://github.com/pulumi/pulumi-aws/pull/4384](https://redirect.github.com/pulumi/pulumi-aws/pull/4384)
- Upgrade upstream to v5.64.0 by
[@&#8203;flostadler](https://redirect.github.com/flostadler) in
[https://github.com/pulumi/pulumi-aws/pull/4395](https://redirect.github.com/pulumi/pulumi-aws/pull/4395)
- Add example for deploying an application from the serverless app
repository by
[@&#8203;flostadler](https://redirect.github.com/flostadler) in
[https://github.com/pulumi/pulumi-aws/pull/4396](https://redirect.github.com/pulumi/pulumi-aws/pull/4396)
- Update region list by
[@&#8203;corymhall](https://redirect.github.com/corymhall) in
[https://github.com/pulumi/pulumi-aws/pull/4404](https://redirect.github.com/pulumi/pulumi-aws/pull/4404)
- Move GRPC tests to yaml by
[@&#8203;VenelinMartinov](https://redirect.github.com/VenelinMartinov)
in
[https://github.com/pulumi/pulumi-aws/pull/4409](https://redirect.github.com/pulumi/pulumi-aws/pull/4409)
- Update GitHub Actions workflows. by
[@&#8203;pulumi-bot](https://redirect.github.com/pulumi-bot) in
[https://github.com/pulumi/pulumi-aws/pull/4420](https://redirect.github.com/pulumi/pulumi-aws/pull/4420)
- Rename the custom workflow to avoid deletion by ci-mgmt PRs by
[@&#8203;t0yv0](https://redirect.github.com/t0yv0) in
[https://github.com/pulumi/pulumi-aws/pull/4418](https://redirect.github.com/pulumi/pulumi-aws/pull/4418)
- Update GitHub Actions workflows. by
[@&#8203;pulumi-bot](https://redirect.github.com/pulumi-bot) in
[https://github.com/pulumi/pulumi-aws/pull/4423](https://redirect.github.com/pulumi/pulumi-aws/pull/4423)
- Enable PlanResourceChange by
[@&#8203;t0yv0](https://redirect.github.com/t0yv0) in
[https://github.com/pulumi/pulumi-aws/pull/4419](https://redirect.github.com/pulumi/pulumi-aws/pull/4419)
- Upstream 5.65.0 by [@&#8203;t0yv0](https://redirect.github.com/t0yv0)
in
[https://github.com/pulumi/pulumi-aws/pull/4425](https://redirect.github.com/pulumi/pulumi-aws/pull/4425)
- Update GitHub Actions workflows. by
[@&#8203;pulumi-bot](https://redirect.github.com/pulumi-bot) in
[https://github.com/pulumi/pulumi-aws/pull/4434](https://redirect.github.com/pulumi/pulumi-aws/pull/4434)
- Update GitHub Actions workflows. by
[@&#8203;pulumi-bot](https://redirect.github.com/pulumi-bot) in
[https://github.com/pulumi/pulumi-aws/pull/4436](https://redirect.github.com/pulumi/pulumi-aws/pull/4436)
- Upgrade pulumi-terraform-bridge to v3.90.0 by
[@&#8203;pulumi-bot](https://redirect.github.com/pulumi-bot) in
[https://github.com/pulumi/pulumi-aws/pull/4439](https://redirect.github.com/pulumi/pulumi-aws/pull/4439)

**Full Changelog**:
pulumi/pulumi-aws@v6.50.1...v6.51.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://redirect.github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43MS4wIiwidXBkYXRlZEluVmVyIjoiMzguNzEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsidHlwZS9taW5vciJdfQ==-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Destroying security group does not respect customTimeouts
3 participants