chore: SkipInstall for tests that do not need it #4315
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the YAML tests only need the AWS provider. Unless the SkipInstall option is specified, they will attempt to
download the latest version of the provider before realizing there is an ambient in-process version to test with. This
can cause sporadic CI failures unrelated to the test. Specifying SkipInstall optimizes away this redundant step.
Example failure log addressed here:
pulumiTest.go:103: failed to install packages and plugins: exit status 255
resource plugin aws installing
warning: Error downloading plugin: unknown version for plugin aws
Will retry in 80ms [1/5]
warning: Error downloading plugin: unknown version for plugin aws
Will retry in 160ms [2/5]
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
corymhall
approved these changes
Jul 29, 2024
t0yv0
deleted the
t0yv0/skip-install-for-tests-that-only-need-local-aws-provider
branch
lumiere-bot bot
referenced
this pull request
in coolguy1771/home-ops
Aug 8, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@pulumi/aws](https://pulumi.io) ([source](https://togithub.com/pulumi/pulumi-aws)) | dependencies | minor | [`6.47.0` -> `6.48.0`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.47.0/6.48.0) | --- ### Release Notes <details> <summary>pulumi/pulumi-aws (@​pulumi/aws)</summary> ### [`v6.48.0`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.48.0) [Compare Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.47.0...v6.48.0) ##### Does the PR have any schema changes? Found 2 breaking changes: ##### Resources - `🟢` "aws:ec2/vpcIpv6CidrBlockAssociation:VpcIpv6CidrBlockAssociation": required: "ipv6IpamPoolId" property is no longer Required ##### Types - `🟢` "aws:rds/ClusterRestoreToPointInTime:ClusterRestoreToPointInTime": required: "sourceClusterIdentifier" property is no longer Required ##### New resources: - `chatbot/slackChannelConfiguration.SlackChannelConfiguration` - `chatbot/teamsChannelConfiguration.TeamsChannelConfiguration` - `datazone/glossary.Glossary` - `ecr/repositoryCreationTemplate.RepositoryCreationTemplate` - `timestreaminfluxdb/dbInstance.DbInstance` ##### New functions: - `ecr/getRepositoryCreationTemplate.getRepositoryCreationTemplate` ##### What's Changed - chore: SkipInstall for tests that do not need it by [@​t0yv0](https://togithub.com/t0yv0) in [https://github.com/pulumi/pulumi-aws/pull/4315](https://togithub.com/pulumi/pulumi-aws/pull/4315) - Upstream v5.61.0 by [@​corymhall](https://togithub.com/corymhall) in [https://github.com/pulumi/pulumi-aws/pull/4341](https://togithub.com/pulumi/pulumi-aws/pull/4341) **Full Changelog**: pulumi/pulumi-aws@v6.47.0...v6.48.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xOC4xNiIsInVwZGF0ZWRJblZlciI6IjM4LjE4LjE2IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL21pbm9yIl19--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
lumiere-bot bot
referenced
this pull request
in coolguy1771/home-ops
Aug 8, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@pulumi/aws](https://pulumi.io) ([source](https://togithub.com/pulumi/pulumi-aws)) | dependencies | minor | [`6.47.0` -> `6.48.0`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.47.0/6.48.0) | --- ### Release Notes <details> <summary>pulumi/pulumi-aws (@​pulumi/aws)</summary> ### [`v6.48.0`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.48.0) [Compare Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.47.0...v6.48.0) ##### Does the PR have any schema changes? Found 2 breaking changes: ##### Resources - `🟢` "aws:ec2/vpcIpv6CidrBlockAssociation:VpcIpv6CidrBlockAssociation": required: "ipv6IpamPoolId" property is no longer Required ##### Types - `🟢` "aws:rds/ClusterRestoreToPointInTime:ClusterRestoreToPointInTime": required: "sourceClusterIdentifier" property is no longer Required ##### New resources: - `chatbot/slackChannelConfiguration.SlackChannelConfiguration` - `chatbot/teamsChannelConfiguration.TeamsChannelConfiguration` - `datazone/glossary.Glossary` - `ecr/repositoryCreationTemplate.RepositoryCreationTemplate` - `timestreaminfluxdb/dbInstance.DbInstance` ##### New functions: - `ecr/getRepositoryCreationTemplate.getRepositoryCreationTemplate` ##### What's Changed - chore: SkipInstall for tests that do not need it by [@​t0yv0](https://togithub.com/t0yv0) in [https://github.com/pulumi/pulumi-aws/pull/4315](https://togithub.com/pulumi/pulumi-aws/pull/4315) - Upstream v5.61.0 by [@​corymhall](https://togithub.com/corymhall) in [https://github.com/pulumi/pulumi-aws/pull/4341](https://togithub.com/pulumi/pulumi-aws/pull/4341) **Full Changelog**: pulumi/pulumi-aws@v6.47.0...v6.48.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xOC4xNiIsInVwZGF0ZWRJblZlciI6IjM4LjE4LjE2IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL21pbm9yIl19--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the YAML tests only need the AWS provider. Unless the SkipInstall option is specified, they will attempt to download the latest version of the provider before realizing there is an ambient in-process version to test with. This can cause sporadic CI failures unrelated to the test. Specifying SkipInstall optimizes away this redundant step.
Example failure log addressed here: