chore: TestIMDSAuth is very slow #4298
Merged
+48
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `TestIMDSAuth` test frequently takes ~45 minutes to run. Looking into it more it looks like the `command:remote:CopyFile` takes the bulk of the time and I am not sure why. Copying the file to S3 via `BucketObjectV2` and then using the userData to copy the file from S3 during instance start up seems to be significantly faster
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
|
Maybe it was installing the command provider and getting throttled? @thomas11 any other guesses? |
t0yv0
approved these changes
Jul 25, 2024
Downloading the Command provider could also be a noticeable chunk. |
|
This PR has been shipped in release v6.47.0. |
lumiere-bot bot
referenced
this pull request
in coolguy1771/home-ops
Jul 30, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@pulumi/aws](https://pulumi.io) ([source](https://togithub.com/pulumi/pulumi-aws)) | dependencies | minor | [`6.46.0` -> `6.47.0`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.46.0/6.47.0) | --- ### Release Notes <details> <summary>pulumi/pulumi-aws (@​pulumi/aws)</summary> ### [`v6.47.0`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.47.0) [Compare Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.46.0...v6.47.0) ##### Does the PR have any schema changes? Found 6 breaking changes: ##### Types - `🟡` "aws:appstream/getImageApplication:getImageApplication": properties: "metadata": additional properties type changed from "pulumi.json#/Any" to "string" - "aws:batch/getJobDefinitionEksPropertyPodPropertyContainerResource:getJobDefinitionEksPropertyPodPropertyContainerResource": properties: - `🟡` "limits": additional properties type changed from "pulumi.json#/Any" to "string" - `🟡` "requests": additional properties type changed from "pulumi.json#/Any" to "string" - `🟡` "aws:batch/getJobDefinitionEksPropertyPodPropertyMetadata:getJobDefinitionEksPropertyPodPropertyMetadata": properties: "labels": additional properties type changed from "pulumi.json#/Any" to "string" - `🟡` "aws:batch/getJobDefinitionNodePropertyNodeRangePropertyContainerLogConfiguration:getJobDefinitionNodePropertyNodeRangePropertyContainerLogConfiguration": properties: "options": additional properties type changed from "pulumi.json#/Any" to "string" - `🟡` "aws:bcmdata/ExportExportDataQuery:ExportExportDataQuery": properties: "tableConfigurations": additional properties: additional properties type changed from "pulumi.json#/Any" to "string" ##### New resources: - `shield/subscription.Subscription` ##### New functions: - `index/getServicePrincipal.getServicePrincipal` ##### What's Changed - chore: TestIMDSAuth is very slow by [@​corymhall](https://togithub.com/corymhall) in [https://github.com/pulumi/pulumi-aws/pull/4298](https://togithub.com/pulumi/pulumi-aws/pull/4298) - Update GitHub Actions workflows. by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-aws/pull/4306](https://togithub.com/pulumi/pulumi-aws/pull/4306) - Add basic instructions for upstream upgrades by [@​t0yv0](https://togithub.com/t0yv0) in [https://github.com/pulumi/pulumi-aws/pull/4310](https://togithub.com/pulumi/pulumi-aws/pull/4310) - Upgrade pulumi-terraform-bridge to v3.88.0 by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-aws/pull/4304](https://togithub.com/pulumi/pulumi-aws/pull/4304) - Update GitHub Actions workflows. by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-aws/pull/4312](https://togithub.com/pulumi/pulumi-aws/pull/4312) - Upstream v5.60.0 by [@​t0yv0](https://togithub.com/t0yv0) in [https://github.com/pulumi/pulumi-aws/pull/4309](https://togithub.com/pulumi/pulumi-aws/pull/4309) **Full Changelog**: pulumi/pulumi-aws@v6.46.0...v6.47.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44LjEiLCJ1cGRhdGVkSW5WZXIiOiIzOC44LjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbInR5cGUvbWlub3IiXX0=--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
lumiere-bot bot
referenced
this pull request
in coolguy1771/home-ops
Jul 30, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@pulumi/aws](https://pulumi.io) ([source](https://togithub.com/pulumi/pulumi-aws)) | dependencies | minor | [`6.46.0` -> `6.47.0`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.46.0/6.47.0) | --- ### Release Notes <details> <summary>pulumi/pulumi-aws (@​pulumi/aws)</summary> ### [`v6.47.0`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.47.0) [Compare Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.46.0...v6.47.0) ##### Does the PR have any schema changes? Found 6 breaking changes: ##### Types - `🟡` "aws:appstream/getImageApplication:getImageApplication": properties: "metadata": additional properties type changed from "pulumi.json#/Any" to "string" - "aws:batch/getJobDefinitionEksPropertyPodPropertyContainerResource:getJobDefinitionEksPropertyPodPropertyContainerResource": properties: - `🟡` "limits": additional properties type changed from "pulumi.json#/Any" to "string" - `🟡` "requests": additional properties type changed from "pulumi.json#/Any" to "string" - `🟡` "aws:batch/getJobDefinitionEksPropertyPodPropertyMetadata:getJobDefinitionEksPropertyPodPropertyMetadata": properties: "labels": additional properties type changed from "pulumi.json#/Any" to "string" - `🟡` "aws:batch/getJobDefinitionNodePropertyNodeRangePropertyContainerLogConfiguration:getJobDefinitionNodePropertyNodeRangePropertyContainerLogConfiguration": properties: "options": additional properties type changed from "pulumi.json#/Any" to "string" - `🟡` "aws:bcmdata/ExportExportDataQuery:ExportExportDataQuery": properties: "tableConfigurations": additional properties: additional properties type changed from "pulumi.json#/Any" to "string" ##### New resources: - `shield/subscription.Subscription` ##### New functions: - `index/getServicePrincipal.getServicePrincipal` ##### What's Changed - chore: TestIMDSAuth is very slow by [@​corymhall](https://togithub.com/corymhall) in [https://github.com/pulumi/pulumi-aws/pull/4298](https://togithub.com/pulumi/pulumi-aws/pull/4298) - Update GitHub Actions workflows. by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-aws/pull/4306](https://togithub.com/pulumi/pulumi-aws/pull/4306) - Add basic instructions for upstream upgrades by [@​t0yv0](https://togithub.com/t0yv0) in [https://github.com/pulumi/pulumi-aws/pull/4310](https://togithub.com/pulumi/pulumi-aws/pull/4310) - Upgrade pulumi-terraform-bridge to v3.88.0 by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-aws/pull/4304](https://togithub.com/pulumi/pulumi-aws/pull/4304) - Update GitHub Actions workflows. by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-aws/pull/4312](https://togithub.com/pulumi/pulumi-aws/pull/4312) - Upstream v5.60.0 by [@​t0yv0](https://togithub.com/t0yv0) in [https://github.com/pulumi/pulumi-aws/pull/4309](https://togithub.com/pulumi/pulumi-aws/pull/4309) **Full Changelog**: pulumi/pulumi-aws@v6.46.0...v6.47.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44LjEiLCJ1cGRhdGVkSW5WZXIiOiIzOC44LjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbInR5cGUvbWlub3IiXX0=--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TestIMDSAuthtest frequently takes ~45 minutes to run. Looking into it more it looks like thecommand:remote:CopyFiletakes the bulk of the time and I am not sure why. Copying the file to S3 viaBucketObjectV2and then using the userData to copy the file from S3 during instance start up seems to be significantly fasterThe test went from ~40minutes to ~4 minutes.