chore: fix flaky test #4228
Merged
chore: fix flaky test #4228
+0
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test has been failing recently due to a resource with the same name already existing. I think we have been running into a race condition between different jobs. Remove the hardcoded name.
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
|
This PR has been shipped in release v6.45.0. |
lumiere-bot bot
referenced
this pull request
in coolguy1771/home-ops
Jul 17, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@pulumi/aws](https://pulumi.io) ([source](https://togithub.com/pulumi/pulumi-aws)) | dependencies | minor | [`6.44.0` -> `6.45.0`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.44.0/6.45.0) | --- ### Release Notes <details> <summary>pulumi/pulumi-aws (@​pulumi/aws)</summary> ### [`v6.45.0`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.45.0) [Compare Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.44.0...v6.45.0) ##### Does the PR have any schema changes? Found 2 breaking changes: ##### Types - `🟢` "aws:ec2/getLaunchTemplateNetworkInterface:getLaunchTemplateNetworkInterface": required: "primaryIpv6" property has changed to Required - `🟢` "aws:eks/getClusterAccessConfig:getClusterAccessConfig": required: "bootstrapClusterCreatorAdminPermissions" property has changed to Required ##### New resources: - `cloudwatch/logAccountPolicy.LogAccountPolicy` - `verifiedpermissions/identitySource.IdentitySource` ##### What's Changed - Update GitHub Actions workflows. by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-aws/pull/4202](https://togithub.com/pulumi/pulumi-aws/pull/4202) - Update GitHub Actions workflows. by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-aws/pull/4209](https://togithub.com/pulumi/pulumi-aws/pull/4209) - Upstream v5.58.0 by [@​flostadler](https://togithub.com/flostadler) in [https://github.com/pulumi/pulumi-aws/pull/4217](https://togithub.com/pulumi/pulumi-aws/pull/4217) - chore: fix flaky test by [@​corymhall](https://togithub.com/corymhall) in [https://github.com/pulumi/pulumi-aws/pull/4228](https://togithub.com/pulumi/pulumi-aws/pull/4228) - chore: use pulumi v3.124.1 in examples by [@​corymhall](https://togithub.com/corymhall) in [https://github.com/pulumi/pulumi-aws/pull/4233](https://togithub.com/pulumi/pulumi-aws/pull/4233) **Full Changelog**: pulumi/pulumi-aws@v6.44.0...v6.45.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL21pbm9yIl19--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
lumiere-bot bot
referenced
this pull request
in coolguy1771/home-ops
Jul 17, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@pulumi/aws](https://pulumi.io) ([source](https://togithub.com/pulumi/pulumi-aws)) | dependencies | minor | [`6.44.0` -> `6.45.0`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.44.0/6.45.0) | --- ### Release Notes <details> <summary>pulumi/pulumi-aws (@​pulumi/aws)</summary> ### [`v6.45.0`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.45.0) [Compare Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.44.0...v6.45.0) ##### Does the PR have any schema changes? Found 2 breaking changes: ##### Types - `🟢` "aws:ec2/getLaunchTemplateNetworkInterface:getLaunchTemplateNetworkInterface": required: "primaryIpv6" property has changed to Required - `🟢` "aws:eks/getClusterAccessConfig:getClusterAccessConfig": required: "bootstrapClusterCreatorAdminPermissions" property has changed to Required ##### New resources: - `cloudwatch/logAccountPolicy.LogAccountPolicy` - `verifiedpermissions/identitySource.IdentitySource` ##### What's Changed - Update GitHub Actions workflows. by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-aws/pull/4202](https://togithub.com/pulumi/pulumi-aws/pull/4202) - Update GitHub Actions workflows. by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [https://github.com/pulumi/pulumi-aws/pull/4209](https://togithub.com/pulumi/pulumi-aws/pull/4209) - Upstream v5.58.0 by [@​flostadler](https://togithub.com/flostadler) in [https://github.com/pulumi/pulumi-aws/pull/4217](https://togithub.com/pulumi/pulumi-aws/pull/4217) - chore: fix flaky test by [@​corymhall](https://togithub.com/corymhall) in [https://github.com/pulumi/pulumi-aws/pull/4228](https://togithub.com/pulumi/pulumi-aws/pull/4228) - chore: use pulumi v3.124.1 in examples by [@​corymhall](https://togithub.com/corymhall) in [https://github.com/pulumi/pulumi-aws/pull/4233](https://togithub.com/pulumi/pulumi-aws/pull/4233) **Full Changelog**: pulumi/pulumi-aws@v6.44.0...v6.45.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL21pbm9yIl19--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test has been failing recently due to a resource with the same name
already existing. I think we have been running into a race condition
between different jobs.
Remove the hardcoded name.