-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only install new pulumi version when there's a newer one available #1225
Merged
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
Users can pass 'latest' as the 'pulumi-version' configuration setting. This currently means that they always download the latest version of the CLI, regardless of whether that's already installed or not. We can do better here and check if the latest version matches the one already installed on the runner, and in that case skip the download.
d6aef7d
to
46340ea
Compare
lunaris
approved these changes
Jul 11, 2024
julienp
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This PR has been shipped in release v5.3.3. |
This was referenced Jul 26, 2024
Merged
This was referenced Aug 23, 2024
Merged
Merged
This was referenced Sep 30, 2024
Merged
This was referenced Jan 16, 2025
This was referenced Mar 1, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can pass 'latest' as the 'pulumi-version' configuration setting. This currently means that they always download the latest version of the CLI, regardless of whether that's already installed or not.
We can do better here and check if the latest version matches the one already installed on the runner, and in that case skip the download.
Fixes #1221