return error when login fails #1062
Merged
+14
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if the login fails as part of the GitHub action, we just silently ignore that. This can be very confusing when steps further down the line fail, e.g. with "error: PULUMI_ACCESS_TOKEN must be set for login during non-interactive CLI sessions", even thoug the user has set the access token. Instead of just continuing our merry way when the login fails, fail the action and let the user know.
This was referenced Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the login fails as part of the GitHub action, we just silently ignore that. This can be very confusing when steps further down the line fail, e.g. with "error: PULUMI_ACCESS_TOKEN must be set for login during non-interactive CLI sessions", even though the user has set the access token.
Instead of just continuing our merry way when the login fails, fail the action and let the user know.
This might be the cause of #1014. The symptoms match, though it's unclear if there is anything else going on in that issue.
/cc @hisuwh