chore: node 20 as default runtime

[dirien]

Hi,

Node 16 reached the end of life on Sep, 11 2023.

Node 20 is supported on GitHub Runners since https://github.com/actions/runner/releases/tag/v2.308.0.

This PR updates the runtime

[Frassle]

Is this going to cause similar issues in GHE as the 12 to 16 bump caused? #752

[simenandre]

Is this going to cause similar issues in GHE as the 12 to 16 bump caused? #752

It might be, but I think we should think about our approach here. As far as I know, we have two alternatives.

a) Should we bump the action, potentially add a note that for runners without support for Node 16 must stay on v4.

b) Make sure most GitHub Enterprise users can use any current version of our action.

I vote for a). In general, I favor releasing often, even though it produces less compatibility. At least in cases where it's out of our hands (such as upstream stuff or GHA not supporting things). I still think we should support earlier major versions to some point, at least security issues.

What do you think?

[dirien]

Bump to v5 as this will indicate the potential for breaking changes and make this clear in the release notes, would be my suggestion.

[justinvp]

v5 bump makes sense to me

[simenandre]

Let's go!

[jplewa]

When will this update be released?

[MatthewBettonMaif]

Hello,

Since last published release version 4.6.0 (las hour ago) (and not a version 5 as suggested here for a breaking change) we have now this error message :

System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter ''using: node20' is not supported, use 'docker', 'node12' or 'node16' instead.')
   at GitHub.Runner.Worker.ActionManifestManager.ConvertRuns(IExecutionContext executionContext, TemplateContext templateContext, TemplateToken inputsToken, String fileRelativePath, MappingToken outputs)
   at GitHub.Runner.Worker.ActionManifestManager.Load(IExecutionContext executionContext, String manifestFile)

Fail to load pulumi/actions/v4/action.yml

[Frassle]

Sorry about that, a long delay between that change being merged and released and no left over indicator in the changelog to remind us to bump the major version. We'll see if we can yank the 4.6 release and re-release it as 5.0.

[tgummerer]

I just deleted the 4.6.0 release and the corresponding tag, so this should work again. Thanks for reporting this @MatthewBettonMaif

[MatthewBettonMaif]

Thank you for your prompt responses and action :)

I can confirm you that it is now ok