Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of date URL in CSR DV Plan #2625

Closed
MikeOpenHWGroup opened this issue Nov 21, 2024 · 3 comments
Closed

Out of date URL in CSR DV Plan #2625

MikeOpenHWGroup opened this issue Nov 21, 2024 · 3 comments
Assignees
Labels
Component:Doc For issues in the Documentation (e.g. for README.md files) Component:Verif For issues in the verification environment or test cases (e.g. for testbench, C code, etc.) CV32A65X Part: Embedded configuration Good First Issue Good first issue to work on if you want to contribute Type:Bug For bugs in the RTL, Documentation, Verification environment or Tool and Build system

Comments

@MikeOpenHWGroup
Copy link
Member

MikeOpenHWGroup commented Nov 21, 2024

In verif/docs/VerifPlans/csr_access/dvplan_csr-access.md there are multiple instances of references to an out-of-date DV Plan, namely https://docs.openhwgroup.org/projects/cva6-user-manual/01\_cva6\_user/CV32A6\_Control\_Status\_Registers.html.

An example of this appears on line 92.

@MikeOpenHWGroup MikeOpenHWGroup added Component:Doc For issues in the Documentation (e.g. for README.md files) Component:Verif For issues in the verification environment or test cases (e.g. for testbench, C code, etc.) Type:Bug For bugs in the RTL, Documentation, Verification environment or Tool and Build system Good First Issue Good first issue to work on if you want to contribute labels Nov 21, 2024
ASintzoff added a commit to ThalesSiliconSecurity/cva6 that referenced this issue Nov 22, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: André Sintzoff <andre.sintzoff@thalesgroup.com>
@MikeOpenHWGroup
Copy link
Member Author

Sorry @ASintzoff, the Issue is still not resolved. In the Markdown file, the URL contains backslashes (\) to escape the underscores (_). These are not needed and are in fact the issue. Line 91 of verif/docs/VerifPlans/csr_access/dvplan_csr-access.md is a good example. Instead of this:

 **Requirement location:** https://docs.openhwgroup.org/projects/cva6-user-manual/01\_cva6\_user/CSR\_CV32A60X.html

we need this:

 **Requirement location:** https://docs.openhwgroup.org/projects/cva6-user-manual/01_cva6_user/CSR_CV32A60X.html

@JeanRochCoulon JeanRochCoulon added the CV32A65X Part: Embedded configuration label Jan 2, 2025
ASintzoff added a commit to ThalesSiliconSecurity/cva6 that referenced this issue Jan 17, 2025
Signed-off-by: André Sintzoff <andre.sintzoff@thalesgroup.com>
JeanRochCoulon pushed a commit that referenced this issue Jan 22, 2025
Previous fix was not correct (PR 2627)
Signed-off-by: André Sintzoff <andre.sintzoff@thalesgroup.com>
Co-authored-by: JeanRochCoulon <jean-roch.coulon@thalesgroup.com>
@ASintzoff
Copy link
Contributor

The correct location of dvplan_csr_access.md file is verif/docs/VerifPlans/source which contains correct URLs.

To avoid any confusion, the useless dvplan_csr_access.md file in verif/docs/VerifPlans/csr_access is removed in PR #2739.

@MikeOpenHWGroup
Copy link
Member Author

Thanks @ASintzoff, this resolves the Issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:Doc For issues in the Documentation (e.g. for README.md files) Component:Verif For issues in the verification environment or test cases (e.g. for testbench, C code, etc.) CV32A65X Part: Embedded configuration Good First Issue Good first issue to work on if you want to contribute Type:Bug For bugs in the RTL, Documentation, Verification environment or Tool and Build system
Projects
None yet
Development

No branches or pull requests

3 participants