Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use the cache if the request has a Range header #328

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Don't use the cache if the request has a Range header #328

merged 1 commit into from
Feb 2, 2024

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Feb 1, 2024

fixes #327

@dimbleby dimbleby mentioned this pull request Feb 1, 2024
Closed
woodruffw
woodruffw approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dimbleby, LGTM. I'll let @frostming review as well before merging.

(Also, thanks for adding a test!)

@frostming
Copy link
Contributor

Looks good for now. I think we would have to encode headers as well as the URL as the cache key.

@frostming frostming merged commit 4e267a8 into psf:master Feb 2, 2024
18 checks passed
@woodruffw
Copy link
Member

I think we would have to encode headers as well as the URL as the cache key.

Makes sense!

@dimbleby: Do you need a point release for this fix? If so, I can prep one tonight.

@frostming
Copy link
Contributor

@dimbleby: Do you need a point release for this fix? If so, I can prep one tonight.

I think so, we can cut a 0.14.0 release

@dimbleby
Copy link
Contributor Author

dimbleby commented Feb 2, 2024

thanks folks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw woodruffw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

download of partial content is defeated by cachecontrol
3 participants
@dimbleby @frostming @woodruffw