Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually use result of best_effort_relative_path #4242

Closed
wants to merge 1 commit into from
Closed

Actually use result of best_effort_relative_path #4242

wants to merge 1 commit into from

Commits on Feb 19, 2024

  1. Update __init__.py 

    Don't clobber result of best_effort_relative_path.
Some how this was missed during but we had:
     root_relative_path = best_effort_relative_path(path, root).as_posix()
            root_relative_path = "/" + root_relative_path

Obviously not what was intended in PR #4222
    @reporter123
    reporter123 committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    fd0695c View commit details
    Browse the repository at this point in the history