Remove redundant parentheses in case statement if guards
#4214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A follow up to psf#4024 but for `if` guards in `case` statements. I noticed this when psf#4024 was made stable, and noticed I had some code that had extra parens around the `if` guard. There might be some edge cases I am not thinking of, but all tests are passing. I put these new changes under the `remove_redundant_guard_parens` preview name.
|
|
||
| match 1: | ||
| case _ if ( | ||
| True |
There was a problem hiding this comment.
Add tests with a comment inside the parentheses in various places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A follow up to #4024 but for
ifguards incasestatements. I noticed this when #4024 was made stable, and noticed I had some code that had extra parens around theifguard.There might be some edge cases I am not thinking of, but all tests are passing. I put these new changes under the
remove_redundant_guard_parenspreview name.Checklist
CHANGES.mdif necessary?