Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify code in lines.py #4167

Merged
merged 5 commits into from
Jan 25, 2024
Merged

Simplify code in lines.py #4167

merged 5 commits into from
Jan 25, 2024

Commits on Jan 25, 2024

  1. Simplify code in lines.py 

    This has been getting a little messy. These changes neaten things up, we
don't have to keep guarding against `self.previous_line is not None`, we
make it clearer what logic has side effects, we reduce the amount of
code that tricky `before` could touch, etc
    @hauntsaninja
    hauntsaninja committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    0b030da View commit details
    Browse the repository at this point in the history

  2. lol, flake8 does not agree

    @hauntsaninja
    hauntsaninja committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    49befdf View commit details
    Browse the repository at this point in the history

  3. simplify further

    @hauntsaninja
    hauntsaninja committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    1ef2e9a View commit details
    Browse the repository at this point in the history

  4. remove another thing

    @hauntsaninja
    hauntsaninja committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    a0d101f View commit details
    Browse the repository at this point in the history

  5. fixup

    @hauntsaninja
    hauntsaninja committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    ca80799 View commit details
    Browse the repository at this point in the history