Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test preview cases with line-length 1 unless explicitly skipped #4087

Merged
merged 2 commits into from Dec 6, 2023

Conversation

jakkdl
Copy link
Contributor

@jakkdl jakkdl commented Dec 6, 2023

Description

As discussed in #4062 with @JelleZijlstra

  • Add new flag for tests, --no-preview-line-length-1, to be used for test cases known to not work in preview mode with line-length=1.
  • Split out the problematic cases in three cases to separate files.
  • Removed now redundant test case which explicitly tested preview annotations with line-length=1

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

…st cases known to not work in preview mode with line-length=1. Also split out the problematic cases in three cases to separate files. Removed now redundant file which explicitly tested preview annotations with line-length=1
@JelleZijlstra JelleZijlstra added the skip news Pull requests that don't need a changelog entry. label Dec 6, 2023
@JelleZijlstra JelleZijlstra merged commit e4ae213 into psf:main Dec 6, 2023
43 of 44 checks passed
@JelleZijlstra
Copy link
Collaborator

Thank you!

@jakkdl jakkdl deleted the test_preview_line_length_1 branch December 6, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants