Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI failing #3957

Merged
merged 4 commits into from Oct 23, 2023
Merged

Fix CI failing #3957

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
10379ac
Fix CI failing
kiyoon Oct 19, 2023
94ef0de
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 19, 2023
ec6de4e
docs: update CHANGES.md
kiyoon Oct 19, 2023
329728e
docs: fix changelog location to unreleased
kiyoon Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGES.md
View file
Open in desktop
Expand Up @@ -47,6 +47,12 @@
<!-- Major changes to documentation and policies. Small docs changes
don't need a changelog entry. -->

## 23.10.1

### Integrations

- Fix the action failing when Black check doesn't pass (#3957)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go into the "Unreleased" section above. We'll set this to 23.10.1 when we make the release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


## 23.10.0

### Stable style
Expand Down
3 changes: 3 additions & 0 deletions action.yml
View file
Open in desktop
Expand Up @@ -35,6 +35,9 @@ runs:
steps:
- name: black
run: |
# Even when black fails, do not close the shell
set +e

if [ "$RUNNER_OS" == "Windows" ]; then
runner="python"
else
Expand Down