Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document disabling E704 #3888

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Document disabling E704 #3888

merged 2 commits into from
Sep 13, 2023

Conversation

hauntsaninja
Copy link
Collaborator

Linking #3887

@hauntsaninja hauntsaninja added the skip news Pull requests that don't need a changelog entry. label Sep 13, 2023
cooperlees
cooperlees requested changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@cooperlees cooperlees left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably edit our own .flake8 config (or delete it + move to pyproject.yaml which I think is supported now)

@hauntsaninja
Copy link
Collaborator Author

Thanks, updated! As far as I can tell, flake8 does not support pyproject.toml, e.g. see PyCQA/flake8#1867 from three days ago

cooperlees
cooperlees approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess time to update my many projects with this too and live with this formatting change.

@hauntsaninja hauntsaninja merged commit e9356c1 into psf:main Sep 13, 2023
38 checks passed
@RedGuy12 RedGuy12 mentioned this pull request Jan 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cooperlees cooperlees cooperlees approved these changes

Assignees
No one assigned
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hauntsaninja @cooperlees