New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More concise formatting for dummy implementations #3796
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9a10436
[ignore] curious for diff shade output
hauntsaninja c38a470
empty lines
hauntsaninja aaf9f5e
remove final annotation
hauntsaninja e5aaaa3
test
hauntsaninja 44378ab
test + changelog
hauntsaninja 5b228b1
more test case
hauntsaninja 7de270e
change logic
hauntsaninja b1c4014
include colon
hauntsaninja f140252
better variable
hauntsaninja File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,99 @@ | ||
from typing import NoReturn, Protocol, Union, overload | ||
|
||
|
||
def dummy(a): ... | ||
def other(b): ... | ||
|
||
|
||
@overload | ||
def a(arg: int) -> int: ... | ||
@overload | ||
hauntsaninja marked this conversation as resolved.
Show resolved
Hide resolved
|
||
def a(arg: str) -> str: ... | ||
@overload | ||
def a(arg: object) -> NoReturn: ... | ||
def a(arg: Union[int, str, object]) -> Union[int, str]: | ||
if not isinstance(arg, (int, str)): | ||
raise TypeError | ||
return arg | ||
|
||
class Proto(Protocol): | ||
def foo(self, a: int) -> int: | ||
... | ||
|
||
def bar(self, b: str) -> str: ... | ||
def baz(self, c: bytes) -> str: | ||
... | ||
|
||
|
||
def dummy_two(): | ||
... | ||
@dummy | ||
def dummy_three(): | ||
... | ||
|
||
def dummy_four(): | ||
... | ||
|
||
@overload | ||
def b(arg: int) -> int: ... | ||
|
||
@overload | ||
def b(arg: str) -> str: ... | ||
@overload | ||
def b(arg: object) -> NoReturn: ... | ||
|
||
def b(arg: Union[int, str, object]) -> Union[int, str]: | ||
if not isinstance(arg, (int, str)): | ||
raise TypeError | ||
return arg | ||
|
||
# output | ||
|
||
from typing import NoReturn, Protocol, Union, overload | ||
|
||
|
||
def dummy(a): ... | ||
def other(b): ... | ||
|
||
|
||
@overload | ||
def a(arg: int) -> int: ... | ||
@overload | ||
def a(arg: str) -> str: ... | ||
@overload | ||
def a(arg: object) -> NoReturn: ... | ||
def a(arg: Union[int, str, object]) -> Union[int, str]: | ||
if not isinstance(arg, (int, str)): | ||
raise TypeError | ||
return arg | ||
|
||
|
||
class Proto(Protocol): | ||
def foo(self, a: int) -> int: ... | ||
|
||
def bar(self, b: str) -> str: ... | ||
def baz(self, c: bytes) -> str: ... | ||
|
||
|
||
def dummy_two(): ... | ||
@dummy | ||
def dummy_three(): ... | ||
|
||
|
||
def dummy_four(): ... | ||
|
||
|
||
@overload | ||
def b(arg: int) -> int: ... | ||
|
||
|
||
@overload | ||
def b(arg: str) -> str: ... | ||
@overload | ||
def b(arg: object) -> NoReturn: ... | ||
|
||
|
||
def b(arg: Union[int, str, object]) -> Union[int, str]: | ||
if not isinstance(arg, (int, str)): | ||
raise TypeError | ||
return arg |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mirrors
is_stub_class
from a couple lines above