Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrease cost of ipynb code path when unneeded #3748

Merged
merged 6 commits into from Jun 27, 2023
Merged

Decrease cost of ipynb code path when unneeded #3748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
98304e0
Decrease cost of ipynb code path when unneeded
hauntsaninja Jun 24, 2023
2c270a4
changelog
hauntsaninja Jun 24, 2023
9d86694
isort
hauntsaninja Jun 24, 2023
0297c9c
format
hauntsaninja Jun 24, 2023
6a0b46d
comment
hauntsaninja Jun 24, 2023
467a2c9
lint
hauntsaninja Jun 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.md
View file
Open in desktop
Expand Up @@ -45,6 +45,8 @@

<!-- Changes that improve Black's performance. -->

- Avoid importing `IPython` in a case where we wouldn't need it (#3748)

### Output

<!-- Changes to Black's terminal output and error messages -->
Expand Down
7 changes: 6 additions & 1 deletion src/black/handle_ipynb_magics.py
View file
Open in desktop
Expand Up @@ -58,8 +58,13 @@ class Replacement:
@lru_cache()
def jupyter_dependencies_are_installed(*, verbose: bool, quiet: bool) -> bool:
try:
import IPython # noqa:F401
# isort: off
hauntsaninja marked this conversation as resolved.
Show resolved Hide resolved
# tokenize_rt is less commonly installed than IPython
# and IPython is expensive to import
import tokenize_rt # noqa:F401
import IPython # noqa:F401

# isort: on
except ModuleNotFoundError:
if verbose or not quiet:
msg = (
Expand Down