Fix CI failing #3957
Merged
Fix CI failing #3957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Thanks! Could you add a NEWS entry since this fixes a user-visible issue? We'll probably cut a hotfix release for this. |
|
By NEWS entry, you mean in CHANGELOG? |
cooperlees
approved these changes
Oct 19, 2023
|
I think we need to fix the pre-commit checks elsewhere ourselves if I'm reading them correctly? |
CHANGES.md
Outdated
|
|
||
| ### Integrations | ||
|
|
||
| - Fix the action failing when Black check doesn't pass (#3957) |
There was a problem hiding this comment.
This should go into the "Unreleased" section above. We'll set this to 23.10.1 when we make the release.
JelleZijlstra
approved these changes
Oct 19, 2023
|
You can see that this is running with a failing file here: https://github.com/kiyoon/blacktest/actions/runs/6578198222 And also the successful run: |
|
Hey, I noticed today the comment in the original PR: #3914 (comment) My proposal was to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3953
Checklist - did you ...
CHANGES.mdif necessary?