Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confine pre-commit to stages #4

Closed
wants to merge 1 commit into from
Closed

confine pre-commit to stages #4

wants to merge 1 commit into from

Conversation

Gjgarr
Copy link

@Gjgarr Gjgarr commented Nov 8, 2023

Originally done upstream in psf/black#3940

See https://pre-commit.com/#confining-hooks-to-run-at-certain-stages

If you are authoring a tool, it is usually a good idea to provide an appropriate stages property. For example a reasonable setting for a linter or code formatter would be stages: [pre-commit, pre-merge-commit, pre-push, manual].

See https://pre-commit.com/#confining-hooks-to-run-at-certain-stages

> If you are authoring a tool, it is usually a good idea to provide an appropriate `stages` property. For example a reasonable setting for a linter or code formatter would be `stages: [pre-commit, pre-merge-commit, pre-push, manual]`.

Originally done upstream in psf/black#3940
Copy link

@CoolCat467 CoolCat467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a good change to have from upstream

@Gjgarr
Copy link
Author

Gjgarr commented Dec 12, 2023

I am waiting for the following black PRs to come to a conclusion before making further updates to this PR

@hauntsaninja
Copy link
Collaborator

Thanks, but we made the decision to revert the upstream change for now in psf/black#4137 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants