Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Change: Removed obsolete/duplicate setup.py from Python. #15708

Merged
merged 1 commit into from Feb 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 15 additions & 4 deletions python/README.md
Expand Up @@ -2,6 +2,11 @@

This directory contains the Protobuf library for Python.

For user documentation about how to use Protobuf Python, see
https://protobuf.dev/getting-started/pythontutorial/

# Installation

In most cases you should install the library using `pip` or another package
manager:

Expand All @@ -12,10 +17,7 @@ $ pip install protobuf
The packages released on https://pypi.org/project/protobuf/#files include both a
source distribution and binary wheels.

For user documentation about how to use Protobuf Python, see
https://protobuf.dev/getting-started/pythontutorial/

# Building packages from this repo
## Building packages from this repo

If for some reason you wish to build the packages directly from this repo, you
can use the following Bazel commands:
Expand All @@ -29,6 +31,15 @@ The binary wheel will build against whatever version of Python is installed on
your system. The source package is always the same and does not depend on a
local version of Python.

## Building from `setup.py`

We support building from `setup.py`, but only from a Python source package.
You cannot build from `setup.py` using the GitHub repo or the GitHub source
tarball.

To build a source package from this repo, see the instructions in the previous
section.

# Implementation backends

There are three separate implementations of Python Protobuf. All of them offer
Expand Down
3 changes: 0 additions & 3 deletions python/build_targets.bzl
Expand Up @@ -461,7 +461,6 @@ def build_targets(name):
":python_src_files",
"README.md",
"google/__init__.py",
"setup.cfg",
],
strip_prefix = "",
visibility = ["//python/dist:__pkg__"],
Expand All @@ -485,8 +484,6 @@ def build_targets(name):
"google/protobuf/python_protobuf.h",
"internal.bzl",
"python_version_test.py",
"setup.cfg",
"setup.py",
],
strip_prefix = strip_prefix.from_root(""),
visibility = ["//pkg:__pkg__"],
Expand Down
2 changes: 0 additions & 2 deletions python/setup.cfg

This file was deleted.