Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport MSVC 32-bit fix #13656

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Backport MSVC 32-bit fix #13656

merged 4 commits into from
Aug 23, 2023

Commits on Aug 23, 2023

  1. Add windows 32-bit tests and re-enable 2022

    PiperOrigin-RevId: 559192056
    mkruskal-google committed Aug 23, 2023
    1 Configuration menu
    Copy the full SHA
    a478e19 View commit details
    Browse the repository at this point in the history
  2. Fixes for 32-bit MSVC.

    Disable the alignment check in 32-bit msvc.
    This toolchain has a difference between "natural" and "required" alignment of
    types and it can have the alignment of members of type `T` to be smaller than
    `alignof(T)`.
    
    Also, disable AnyTest.TestPackFromSerializationExceedsSizeLimit there because it can't allocate that much memory.
    
    PiperOrigin-RevId: 559495544
    protobuf-github-bot authored and mkruskal-google committed Aug 23, 2023
    1 Configuration menu
    Copy the full SHA
    01e1a5c View commit details
    Browse the repository at this point in the history
  3. Merge pull request #13655 from mkruskal-google/backport-tdp-msvc-32

    Backport MSVC 32-bit fix
    mkruskal-google committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    31efbb9 View commit details
    Browse the repository at this point in the history
  4. Remove a flaky test with very high memory requirements.

    PiperOrigin-RevId: 558844591
    mkruskal-google committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    5626baf View commit details
    Browse the repository at this point in the history