Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodule abseil-app branch to lts_2023_01_25 #12434

Closed

Conversation

Aiemu
Copy link

@Aiemu Aiemu commented Apr 10, 2023

I encountered a compilation error while developing in c++, and the following is part of the error:

onnx.pb.cc:(.text._ZN4absl12lts_2023012512log_internal10LogMessagelsILi59EEERS2_RAT__Kc[_ZN4absl12lts_2023012512log_internal10LogMessagelsILi59EEERS2_RAT__Kc]+0x58): undefined reference to `absl::Lts_20230125::log_internal::LogMessage::CopyToEncodedBuffer(std::basic_string_view<char, std::char_traits<char>>, absl::lts_20230125::log_internal::LogMessage::StringType)'

The abseil-cpp dependency declared in third_party third_party is commit 78be636. In absl/base/options.hz in this commit set the absl_lst version to 20230125 as follows:

#define ABSL_LTS_RELEASE_VERSION 20230125

The branch lts_2023_01_24 has now been removed from abseil-cpp, and the .gitmodules still depend on that branch.

@google-cla
Copy link

google-cla bot commented Apr 10, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@deannagarcia deannagarcia self-requested a review April 11, 2023 16:23
@deannagarcia deannagarcia added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Apr 11, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Apr 11, 2023
@JamiKettunen
Copy link

#12453 was merged and did the same change

@deannagarcia
Copy link
Member

Thanks for catching this issue! As pointed out, I merged #12453 and 41b7500 to fix this. So I will go ahead and close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants