Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] fix: do not let setProperty change the prototype (#1899) #1910

Closed

Conversation

jportner
Copy link

Resolves #1909.

This PR backports #1899 to the 6.x branch.

Hopefully this security change can be released as a 6.11.4 version, as many packages rely on protobufjs 6.x and cannot be easily upgraded.

* fix: do not let setProperty change the prototype

* test: add unit test
@jportner
Copy link
Author

@bcoe you reviewed the original PR linked above, would you be able to review this one too?

@jportner jportner changed the title fix: do not let setProperty change the prototype (#1899) [6.x] fix: do not let setProperty change the prototype (#1899) Jul 10, 2023
@mizevkon
Copy link

@bcoe , @alexander-fenster folks, would be awesome if you have a look.

@egasimus
Copy link

This seems to have been released to NPM, but there doesn't seem to be a corresponding release tag on GitHub for people to audit the source code?

@mizevkon
Copy link

Backport was made and published as 6.11.4, though there is no official announcement:
https://github.com/protobufjs/protobuf.js/commits/release-6.11.4

@alexander-fenster
Copy link
Contributor

Sorry, I backported the fix separately without seeing this PR :) Thank you everyone for chiming in here.

I have no idea how to make "official announcement" but the advisory is now updated.

@egasimus
Copy link

@alexander-fenster

how to make "official announcement"

Please at least add 6.11.4 tag to the commit where the fix landed, and from which the package was published to NPM 🙏

@jportner jportner deleted the 6.x-prototype-pollution-fix branch August 23, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants