Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: fix(config): resolve prompt file bug #1722

Merged
merged 1 commit into from
Sep 20, 2024
Merged

revert: fix(config): resolve prompt file bug #1722

merged 1 commit into from
Sep 20, 2024

Conversation

mldangelo
Copy link
Member

@mldangelo mldangelo commented Sep 20, 2024

This reverts commit 92ee2bb.

relates to #1720 #1717 #1716

CC @albertlieyingadrian

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This reverts commit 92ee2bb.
@mldangelo mldangelo self-assigned this Sep 20, 2024
@mldangelo mldangelo merged commit 2e5ddea into main Sep 20, 2024
12 checks passed
@mldangelo mldangelo deleted the revert-1659 branch September 20, 2024 05:19
@albertlieyingadrian
Copy link
Contributor

Thanks! @mldangelo

@albertlieyingadrian
Copy link
Contributor

@mldangelo I created a PR to handle the case when it's a javascript function in case you want to merge your PR back

#1724

Din-m-shin pushed a commit to Din-m-shin/promptfoo that referenced this pull request Sep 24, 2024
Din-m-shin pushed a commit to Din-m-shin/promptfoo that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants