Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker): link peer dependencies in Docker build #1545

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix(docker): link peer dependencies in Docker build #1545

merged 1 commit into from
Aug 28, 2024
+1 −1

Conversation

mldangelo
Copy link
Member

  • Add --install-links flag to npm install command in Dockerfile
  • Ensures peer dependencies listed in package.json are installed in Docker container

Resolves issue with missing peer dependencies in node_modules within Docker image.

Reference

@mldangelo
install peer deps

Verified

This commit was signed with the committer’s verified signature.
wojtekmaj Wojciech Maj
GPG key ID: F0654C838468A4D7
Verified
Learn about vigilant mode
Loading
Loading status checks…
ad7d874
@mldangelo mldangelo changed the title fix(docker): install peer dependencies in Docker build fix(docker): link peer dependencies in Docker build Aug 28, 2024
@mldangelo mldangelo merged commit b4078f2 into main Aug 28, 2024
13 checks passed
@mldangelo mldangelo deleted the fix/retain-peer-dependencies-in-docker-build branch August 28, 2024 21:31
Din-m-shin pushed a commit to Din-m-shin/promptfoo that referenced this pull request Sep 13, 2024
@mldangelo @Din-m-shin
fix(docker): link peer dependencies in Docker build (promptfoo#1545)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
dc6d0d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mldangelo