feat(webui): improve download menu, add option to download human eval test cases, and add tests #1500
+336
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mldangelo
commented
Aug 22, 2024
mldangelo
commented
- Add unit tests for DownloadMenu component
- Enhance DownloadMenu UI with tooltips, dividers, and grouped options
- Implement keyboard shortcuts for download options
…ownload - Implement number key shortcuts (1-5) for download options - Add new download option for Human Eval Test Cases - Improve button layout with right-aligned shortcut indicators - Add keyboard event listener to handle shortcuts when dialog is open
typpo
approved these changes
Aug 22, 2024
| </Button> | ||
| </Tooltip> | ||
|
|
||
| <Tooltip title="Download Human Evaluation Test Cases in YAML format"> |
There was a problem hiding this comment.
is "Human Evaluation Test Cases" the right label? Maybe just Evaluation Test Cases? or Promptfoo Evaluation Test Cases?
Din-m-shin
pushed a commit
to Din-m-shin/promptfoo
that referenced
this pull request
Aug 26, 2024
… test cases, and add tests (promptfoo#1500)
Din-m-shin
pushed a commit
to Din-m-shin/promptfoo
that referenced
this pull request
Aug 26, 2024
… test cases, and add tests (promptfoo#1500)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.