Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cut v2.51.0-rc.0 #13729

Merged
merged 6 commits into from Mar 11, 2024
Merged

Cut v2.51.0-rc.0 #13729

merged 6 commits into from Mar 11, 2024

Conversation

bboreham
Copy link
Member

@bboreham bboreham commented Mar 7, 2024

No description provided.

bboreham
bboreham commented Mar 7, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
bboreham
bboreham commented Mar 7, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
ArthurSens
ArthurSens reviewed Mar 7, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@bboreham
Cut v2.51.0-rc.0
53fa230 
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
@bboreham
Changelog: remove some less-relevant items, fix ordering
a0f60ce 
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
@bboreham
Add fixes and one more enhancement
ca277d6 
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
@bboreham
Copy link
Member Author

bboreham commented Mar 8, 2024

Updated with two last-minute fixes and #13681.

@bboreham
Copy link
Member Author

bboreham commented Mar 8, 2024

/prombench v2.50.1

@prombot
Copy link
Contributor

prombot commented Mar 8, 2024

⏱️ Welcome to Prometheus Benchmarking Tool. ⏱️

Compared versions: PR-13729 and v2.50.1

After successful deployment, the benchmarking results can be viewed at:

Other Commands:
To stop benchmark: /prombench cancel
To restart benchmark: /prombench restart v2.50.1

michaelact and others added 3 commits March 8, 2024 15:20
@michaelact @bboreham
[BUGFIX] Azure SD: Fix 'error: parameter virtualMachineScaleSetName c…
699f31a 
…annot be empty' (#13702)

Erroneous code was introduced during a merge-back-to-main at #13399.

Signed-off-by: michaelact <86778470+michaelact@users.noreply.github.com>
@bboreham
Add Azure SD bugfix
b280ace 
And remove mention of change already in 2.50.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
@bboreham
Remove mention of change already in 2.50.1.
392a726 
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
@prombot
Copy link
Contributor

prombot commented Mar 11, 2024

Benchmark tests are running for 3 days! If this is intended ignore this message otherwise you can cancel it by commenting: /prombench cancel

@roidelapluie
Copy link
Member

LGTM, Benchmark is great!

@bboreham
Copy link
Member Author

/prombench cancel

@prombot
Copy link
Contributor

prombot commented Mar 11, 2024

Benchmark cancel is in progress.

@bboreham
Copy link
Member Author

Yes, CPU and range-query latency are down; memory is a little lower.

image

@bboreham bboreham merged commit 8d53e7b into release-2.51 Mar 11, 2024
46 checks passed
@bboreham bboreham deleted the cut-2.51.0-rc.0 branch March 11, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurSens ArthurSens ArthurSens left review comments

@juliusv juliusv Awaiting requested review from juliusv juliusv is a code owner

@Nexucis Nexucis Awaiting requested review from Nexucis Nexucis is a code owner

Assignees
No one assigned
Labels
prombench
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bboreham @prombot @roidelapluie @juliusv @ArthurSens @michaelact