Skip to content

Commit

Permalink
[BUGFIX] Scraping: Tolerance should be max 1% of interval
Browse files Browse the repository at this point in the history
Previous code set it at minimum 1%, which was not intended.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
  • Loading branch information
bboreham committed Mar 8, 2024
1 parent df6ff4e commit 057a706
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions scrape/scrape.go
Expand Up @@ -1218,10 +1218,8 @@ mainLoop:
// and .Add on time.Time behave differently (see time package docs).
scrapeTime := time.Now().Round(0)
if AlignScrapeTimestamps {
tolerance := ScrapeTimestampTolerance
if maxTolerance := sl.interval / 100; tolerance < maxTolerance {
tolerance = maxTolerance
}
// Tolerance is clamped to maximum 1% of the scrape interval.
tolerance := min(sl.interval/100, ScrapeTimestampTolerance)
// For some reason, a tick might have been skipped, in which case we
// would call alignedScrapeTime.Add(interval) multiple times.
for scrapeTime.Sub(alignedScrapeTime) >= sl.interval {
Expand Down

0 comments on commit 057a706

Please sign in to comment.