Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for per-interface SNMP6 stats #693

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

Vascko
Copy link
Contributor

@Vascko Vascko commented Jan 9, 2025

Hi Folks,

I'd love to extend the available IPv6 metrics in Prometheus' Node Exporter to include the per-interface stats from the /proc/net/dev_snmp6/ folder, so I started by adding the ability to get that data via this library.

Tests for the new methods as well as new testdata are included.

Fixed some old references to the fixture path in the docs as well.

@Vascko Vascko force-pushed the master branch 2 times, most recently from a2d37f8 to 0dd21e0 Compare January 9, 2025 10:08
Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@discordianfish
Copy link
Member

Also see linting error

Signed-off-by: Felix Geschwindner <felix.geschwindner@icloud.com>
@discordianfish discordianfish merged commit 5d8dd55 into prometheus:master Feb 3, 2025
9 checks passed
@discordianfish
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants