Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(meminfo): account for optional unit field so values are accurate #569

Merged
merged 3 commits into from
Oct 11, 2023
Merged

fix(meminfo): account for optional unit field so values are accurate #569

merged 3 commits into from
Oct 11, 2023

Commits on Sep 25, 2023

  1. fix(meminfo): account for optional unit field so values are accurate 

    Addresses: prometheus#565

Previously, this function was ignoring the optional unit field, leading
to incorrect results on systems that do report the field. This uses the
humanize lib used elsewhere within the Prometheus ecosystem to normalize
the value to bytes, including when a unit is provided.

To try and maintain existing behavior, the fixed/unit-scaled values are
stored as new struct fields.

Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>
    @tjhop
    tjhop committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    2c71ced View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. ref(meminfo): simplify variable assignment 

    Addresses PR feedback
prometheus#569 (comment)

Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>
    @tjhop
    tjhop committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    f7b4621 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. fix(meminfo): remove bytes versions of fields that aren't bytes 

    Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>
    @tjhop
    tjhop committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    325db76 View commit details
    Browse the repository at this point in the history