Support old conntrack stats #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linux < 2.6.35 was missing the `search_restart` field in nf_conntrack. * Refactor stat parsing to simplify code. * Support 16-field nf_conntrack entries. * Support additional fields. Fixes: #499 Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
force-pushed
the
superq/conntrack_old_kernel
branch
from
bc5ff9c
to
d193bd7
Compare
pgier
approved these changes
Mar 15, 2023
| @@ -64,6 +64,21 @@ func ParsePInt64s(ss []string) ([]*int64, error) { | |||
| return us, nil | |||
| } | |||
|
|
|||
| // Parses a uint64 from given hex in string. | |||
| func ParseHexUint64s(ss []string) ([]*uint64, error) { | |||
| us := make([]*uint64, 0, len(ss)) | |||
There was a problem hiding this comment.
Could this return a uint64 slice instead of *uint64?
There was a problem hiding this comment.
It could, I was following the pattern of the other string parsers here.
discordianfish
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux < 2.6.35 was missing the
search_restartfield in nf_conntrack.Fixes: #499